Skip to content

Small fixes from #7701 #9128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fokko wants to merge 1 commit into from
Closed

Small fixes from #7701 #9128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...fka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/KafkaIOConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public class KafkaIOConfigTest
public KafkaIOConfigTest()
{
mapper = new DefaultObjectMapper();
mapper.registerModules((Iterable<Module>) new KafkaIndexTaskModule().getJacksonModules());
mapper.registerModules(new KafkaIndexTaskModule().getJacksonModules());
}

@Rule
Expand Down
14 changes: 7 additions & 7 deletions indexing-hadoop/src/main/java/org/apache/druid/indexer/IndexGeneratorJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,13 @@ public static List<DataSegment> getPublishedSegments(HadoopDruidIndexerConfig co

final Path descriptorInfoDir = config.makeDescriptorInfoDir();

try {
FileSystem fs = descriptorInfoDir.getFileSystem(conf);

try (FileSystem fs = descriptorInfoDir.getFileSystem(conf)) {
Copy link
Copy Markdown
Contributor

@jihoonson jihoonson Jan 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fokko, would you elaborate more on this change? Seems like Path.getFileSystem() returns a cached instance of a FileSystem and I guess it might be better to leave the cached one rather than removing it from the cache?

for (FileStatus status : fs.listStatus(descriptorInfoDir)) {
final DataSegment segment = jsonMapper.readValue((InputStream) fs.open(status.getPath()), DataSegment.class);
publishedSegmentsBuilder.add(segment);
log.info("Adding segment %s to the list of published segments", segment.getId());
try (InputStream input = fs.open(status.getPath())) {
final DataSegment segment = jsonMapper.readValue(input, DataSegment.class);
publishedSegmentsBuilder.add(segment);
log.info("Adding segment %s to the list of published segments", segment.getId());
}
}
}
catch (FileNotFoundException e) {
Expand All @@ -140,7 +140,7 @@ public static List<DataSegment> getPublishedSegments(HadoopDruidIndexerConfig co
}

private final HadoopDruidIndexerConfig config;
private IndexGeneratorStats jobStats;
private final IndexGeneratorStats jobStats;
private Job job;

public IndexGeneratorJob(
Expand Down