Skip to content

Docs: move search to the left#9190

Closed
vogievetsky wants to merge 1 commit intoapache:masterfrom
implydata:move-search
Closed

Docs: move search to the left#9190
vogievetsky wants to merge 1 commit intoapache:masterfrom
implydata:move-search

Conversation

@vogievetsky
Copy link
Copy Markdown
Contributor

Put the doc search on the left of all the links

image

@fjy
Copy link
Copy Markdown
Contributor

fjy commented Jan 15, 2020

Vadim, can we move the search into the ToC and out of the nav bar?

@fjy
Copy link
Copy Markdown
Contributor

fjy commented Jan 15, 2020

It feels so out of place and hard to find in the nav bar

@ccaominh
Copy link
Copy Markdown
Contributor

The security vulnerabilities travis job failure is unrelated to this PR. Please merge master to get the fix: #9189

@vogievetsky
Copy link
Copy Markdown
Contributor Author

@fjy the docusaurus template forces you to have a search in the header. Putting it in the ToC would be a lot more work. Do you think this position is better than before?

@fjy
Copy link
Copy Markdown
Contributor

fjy commented Jan 21, 2020

@vogievetsky I think it is extremely hard to find the doc search bar and we should try to put it somewhere else. Can we have a sub-header bar or something?

@stale
Copy link
Copy Markdown

stale Bot commented Mar 21, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale Bot added the stale label Mar 21, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Apr 18, 2020

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale Bot closed this Apr 18, 2020
@vogievetsky vogievetsky deleted the move-search branch October 16, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants