Skip to content

remove log.info from FixedBucketsHistogramAggregator aggregate method #9309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjy merged 1 commit into from
Feb 4, 2020
Merged

remove log.info from FixedBucketsHistogramAggregator aggregate method #9309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...in/java/org/apache/druid/query/aggregation/histogram/FixedBucketsHistogramAggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import com.google.common.primitives.Longs;
import org.apache.druid.common.config.NullHandling;
import org.apache.druid.java.util.common.ISE;
import org.apache.druid.java.util.common.logger.Logger;
import org.apache.druid.query.aggregation.Aggregator;
import org.apache.druid.segment.BaseObjectColumnValueSelector;

Expand All @@ -31,8 +30,6 @@

public class FixedBucketsHistogramAggregator implements Aggregator
{
private static final Logger LOG = new Logger(FixedBucketsHistogramAggregator.class);

public static final String TYPE_NAME = "fixedBucketsHistogram";

public static final Comparator COMPARATOR = new Comparator()
Expand Down Expand Up @@ -77,7 +74,6 @@ public void aggregate()
histogram.incrementMissing();
}
} else if (val instanceof String) {
LOG.info((String) val);
Copy link
Copy Markdown
Contributor

@jnaous jnaous Feb 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes for a good review tip!

histogram.combineHistogram(FixedBucketsHistogram.fromBase64((String) val));
} else if (val instanceof FixedBucketsHistogram) {
histogram.combineHistogram((FixedBucketsHistogram) val);
Expand Down
3 changes: 0 additions & 3 deletions ...rc/main/java/org/apache/druid/query/aggregation/histogram/FixedBucketsHistogramSerde.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import org.apache.druid.common.config.NullHandling;
import org.apache.druid.data.input.InputRow;
import org.apache.druid.data.input.Rows;
import org.apache.druid.java.util.common.logger.Logger;
import org.apache.druid.java.util.common.parsers.ParseException;
import org.apache.druid.query.aggregation.AggregatorFactory;
import org.apache.druid.segment.GenericColumnSerializer;
Expand All @@ -41,8 +40,6 @@

public class FixedBucketsHistogramSerde extends ComplexMetricSerde
{
private static final Logger LOG = new Logger(FixedBucketsHistogramSerde.class);

private static Ordering<FixedBucketsHistogram> comparator = new Ordering<FixedBucketsHistogram>()
{
@Override
Expand Down