Fix basic auth polling to skip retries when cachedSerializedGroupMappingMap returns 404#9354
Merged
jon-wei merged 1 commit intoapache:masterfrom Feb 13, 2020
Merged
Conversation
…ingMap returns 404
ccaominh
approved these changes
Feb 13, 2020
jon-wei
added a commit
to jon-wei/druid
that referenced
this pull request
Feb 13, 2020
…ingMap returns 404 (apache#9354)
jon-wei
added a commit
to implydata/druid-public
that referenced
this pull request
Feb 13, 2020
…ingMap returns 404 (apache#9354) (#57)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a rolling upgrade issue that occurs when druid-basic-security extension is used.
cachedSerializedGroupMappingMapis a new endpoint on the coordinator added by #6972 .When a process running 0.17.0 or later is running alongside a coordinator running a version < 0.17.0, the new version process will attempt to fetch info from the ``cachedSerializedGroupMappingMap` endpoint which does not exist until the coordinator is upgraded.
This has the effect of blocking process startup until the retries for that endpoint are exhausted. The impact is worse for tasks launched during the rolling upgrade, as the overlord may kill tasks that take too long to start up.
The PR addresses this issue by having the polling mechanism stop retrying if it receives a 404 from the coordinator for the
cachedSerializedGroupMappingMapendpoint and logging a warning message.This PR has: