Skip to content

Fix basic auth polling to skip retries when cachedSerializedGroupMappingMap returns 404#9354

Merged
jon-wei merged 1 commit intoapache:masterfrom
jon-wei:fix_rolling_upgrade_auth
Feb 13, 2020
Merged

Fix basic auth polling to skip retries when cachedSerializedGroupMappingMap returns 404#9354
jon-wei merged 1 commit intoapache:masterfrom
jon-wei:fix_rolling_upgrade_auth

Conversation

@jon-wei
Copy link
Copy Markdown
Contributor

@jon-wei jon-wei commented Feb 12, 2020

This PR fixes a rolling upgrade issue that occurs when druid-basic-security extension is used.

cachedSerializedGroupMappingMap is a new endpoint on the coordinator added by #6972 .

When a process running 0.17.0 or later is running alongside a coordinator running a version < 0.17.0, the new version process will attempt to fetch info from the ``cachedSerializedGroupMappingMap` endpoint which does not exist until the coordinator is upgraded.

This has the effect of blocking process startup until the retries for that endpoint are exhausted. The impact is worse for tasks launched during the rolling upgrade, as the overlord may kill tasks that take too long to start up.

The PR addresses this issue by having the polling mechanism stop retrying if it receives a 404 from the coordinator for the cachedSerializedGroupMappingMap endpoint and logging a warning message.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Copy Markdown
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jon-wei jon-wei merged commit 48a0681 into apache:master Feb 13, 2020
jon-wei added a commit to jon-wei/druid that referenced this pull request Feb 13, 2020
jon-wei added a commit to implydata/druid-public that referenced this pull request Feb 13, 2020
@jihoonson jihoonson added this to the 0.18.0 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants