Skip to content

Improves on the fix for 8918#9387

Merged
jihoonson merged 5 commits intoapache:masterfrom
showheroes:fix-realtime-task-tests-again
Feb 25, 2020
Merged

Improves on the fix for 8918#9387
jihoonson merged 5 commits intoapache:masterfrom
showheroes:fix-realtime-task-tests-again

Conversation

@frnidito
Copy link
Copy Markdown
Contributor

@frnidito frnidito commented Feb 21, 2020

Improves on the fixes for #8918

Description

It just changes the ITRetryUtil.retryUntilTrue with a ITRetryUtil.retryUntil in order to increase the amount of retries — a little change on top of #8999 —, moreover it changes the number of retries and delay between retries in the HttpUtil to deal with the sporadic 401 errors.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Copy Markdown
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 seems fine to me, I will re-run travis a few times to see if it improves things

@frnidito
Copy link
Copy Markdown
Contributor Author

@clintropolis — I added another retry, can you please re-run travis, or explain me how o do it, to check if it is now better?

@clintropolis
Copy link
Copy Markdown
Member

@clintropolis — I added another retry, can you please re-run travis, or explain me how o do it, to check if it is now better?

I can keep retries going, only committers can restart travis jobs. I've been running it over the last couple of days and so far so good; thanks for looking into this 👍

Copy link
Copy Markdown
Contributor

@jihoonson jihoonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @frnidito!

@jihoonson jihoonson merged commit 14accb5 into apache:master Feb 25, 2020
@jihoonson jihoonson added this to the 0.18.0 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants