Skip to content

remove ServerDiscoverySelector from DruidLeaderClient#9481

Merged
himanshug merged 1 commit intoapache:masterfrom
himanshug:druid_leader_client_zk_removal
Mar 9, 2020
Merged

remove ServerDiscoverySelector from DruidLeaderClient#9481
himanshug merged 1 commit intoapache:masterfrom
himanshug:druid_leader_client_zk_removal

Conversation

@himanshug
Copy link
Copy Markdown
Contributor

@himanshug himanshug commented Mar 9, 2020

Paving Path Towards #9053

Description

This patch removes hard coded use of Zookeeper from DruidLeaderClient. This was originally kept to allow rolling upgrade transition to http based leader finder.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

clintropolis
clintropolis approved these changes Mar 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@himanshug
Copy link
Copy Markdown
Contributor Author

himanshug commented Mar 9, 2020

@clintropolis thanks for quick review.

@himanshug himanshug merged commit 072bbe2 into apache:master Mar 9, 2020
@jihoonson jihoonson added this to the 0.18.0 milestone Mar 26, 2020
ccaominh added a commit to implydata/druid-public that referenced this pull request Apr 15, 2020
@ccaominh
Revert "remove ServerDiscoverySelector from DruidLeaderClient (apache…
9cffc2a 
…#9481)"

This reverts commit 072bbe2.
@jihoonson jihoonson mentioned this pull request Apr 15, 2020
Closed
jihoonson added a commit to jihoonson/druid that referenced this pull request Apr 15, 2020
@jihoonson
Revert "remove ServerDiscoverySelector from DruidLeaderClient (apache…
f1fc7d2 
…#9481)"

This reverts commit 072bbe2.
jihoonson added a commit that referenced this pull request Apr 15, 2020
@jihoonson
Revert "remove ServerDiscoverySelector from DruidLeaderClient (#9481)" (
b8f7128 
#9702)

* Revert "remove ServerDiscoverySelector from DruidLeaderClient (#9481)"

This reverts commit 072bbe2.

* fix build
jihoonson added a commit to jihoonson/druid that referenced this pull request Apr 15, 2020
@jihoonson
Revert "remove ServerDiscoverySelector from DruidLeaderClient (apache…
ab4c603 
…#9481)" (apache#9702)

* Revert "remove ServerDiscoverySelector from DruidLeaderClient (apache#9481)"

This reverts commit 072bbe2.

* fix build
ccaominh added a commit to implydata/druid-public that referenced this pull request Apr 15, 2020
@ccaominh
Revert apache#9481 (#82)
cca84f8 
* Revert "remove ServerDiscoverySelector from DruidLeaderClient (apache#9481)"

This reverts commit 072bbe2.

* Fix test compilation error
jihoonson added a commit that referenced this pull request Apr 15, 2020
@jihoonson
Revert "remove ServerDiscoverySelector from DruidLeaderClient (#9481)" (
09376a2 
#9702) (#9703)

* Revert "remove ServerDiscoverySelector from DruidLeaderClient (#9481)"

This reverts commit 072bbe2.

* fix build
JulianJaffePinterest pushed a commit to JulianJaffePinterest/druid that referenced this pull request Jun 12, 2020
@jihoonson @JulianJaffePinterest
Revert "remove ServerDiscoverySelector from DruidLeaderClient (apache…
14ad338 
…#9481)" (apache#9702)

* Revert "remove ServerDiscoverySelector from DruidLeaderClient (apache#9481)"

This reverts commit 072bbe2.

* fix build
@himanshug himanshug mentioned this pull request Oct 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clintropolis clintropolis clintropolis approved these changes

Assignees

No one assigned

Labels

Area - ZooKeeper/Curator

Projects

None yet

Milestone

0.18.0

Development

Successfully merging this pull request may close these issues.

3 participants

@himanshug @clintropolis @jihoonson