Skip to content

[0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)#9606

Merged
jihoonson merged 2 commits intoapache:0.18.0from
suneet-s:backport/0.18.0/pr-9590
Apr 3, 2020
Merged

[0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)#9606
jihoonson merged 2 commits intoapache:0.18.0from
suneet-s:backport/0.18.0/pr-9590

Conversation

@suneet-s
Copy link
Copy Markdown
Contributor

@suneet-s suneet-s commented Apr 3, 2020

Backports the following commits to 0.18.0:

)

* WIP integration tests

* Add integration test for ingestion with transformSpec

* WIP almost working tests

* Add ignored tests

* checkstyle stuff

* remove newPage from index task ingestion spec

* more test cleanup

* still not quite working

* Actually disable the tests

* working tests

* fix codestyle

* dont use junit in integration tests

* actually fix the bug

* fix checkstyle

* bring index tests closer to reindex tests
@suneet-s
Copy link
Copy Markdown
Contributor Author

suneet-s commented Apr 3, 2020

clean backport

Copy link
Copy Markdown
Contributor

@maytasm maytasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have COMPILATION ERROR from QUICKSTART_COMPATIBLE that was added in master
Suggest removing the QUICKSTART_COMPATIBLE group

@suneet-s
Copy link
Copy Markdown
Contributor Author

suneet-s commented Apr 3, 2020

Looks like you have COMPILATION ERROR from QUICKSTART_COMPATIBLE that was added in master
Suggest removing the QUICKSTART_COMPATIBLE group

👍 thanks for pointing that out

@jihoonson jihoonson merged commit 52d79f5 into apache:0.18.0 Apr 3, 2020
@jihoonson jihoonson added this to the 0.18.0 milestone Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants