Add 0.18.0 to .backportrc.json to facilitate backport.#9661
Merged
ccaominh merged 1 commit intoapache:masterfrom Apr 11, 2020
Merged
Add 0.18.0 to .backportrc.json to facilitate backport.#9661ccaominh merged 1 commit intoapache:masterfrom
ccaominh merged 1 commit intoapache:masterfrom
Conversation
suneet-s
approved these changes
Apr 10, 2020
Contributor
suneet-s
left a comment
There was a problem hiding this comment.
LGTM Thanks @abhishekrb19 !
d0d02fe to
004b5a6
Compare
Contributor
Author
|
One of the tests failed, but appears to be unrelated to this change: However, the test ran fine locally on my mac: @suneet-s, is this a known issue? I force pushed to re-trigger another job to see what happens. |
Contributor
|
#9633 tried to fix this and should have been merged 2 days ago - any chance your branch did not have this change? Usually if it's a flaky test, one of the committers can re-trigger just the failed test on travis so you don't need to do a force push and re-run all the tests. |
Contributor
Author
|
@suneet-s, the commit ❯ git branch --contains 7bf2dfa
fix_markdown_numbered_list
* include_0.18.0_to_backport
masterAh, thanks, good to know about selectively re-triggering failed tests on Travis. |
ccaominh
approved these changes
Apr 11, 2020
JulianJaffePinterest
pushed a commit
to JulianJaffePinterest/druid
that referenced
this pull request
Jun 12, 2020
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@suneet-s, I found the
backport.mddoc useful when trying to backport this fix to0.18.0. Adding0.18.0to the config, so we could just runbackportfrom the repo's working directory. Thanks!