Skip to content

[Backport]druid-pac4j: add ability to use custom ssl trust store while talking to auth server#9675

Merged
jihoonson merged 1 commit intoapache:0.18.0from
himanshug:backport_9637
Apr 11, 2020
Merged

[Backport]druid-pac4j: add ability to use custom ssl trust store while talking to auth server#9675
jihoonson merged 1 commit intoapache:0.18.0from
himanshug:backport_9637

Conversation

@himanshug
Copy link
Copy Markdown
Contributor

@himanshug himanshug commented Apr 11, 2020

backports #9637

@himanshug
druid-pac4j: add ability to use custom ssl trust store while talking …
035f7ac 
…to auth server (apache#9637)

* druid-pac4j: add ability for custom ssl trust store for talking to auth
server

* fix nimbusds DefaultResourceRetriever name in comment
@himanshug himanshug added this to the 0.18.0 milestone Apr 11, 2020
@jihoonson
Copy link
Copy Markdown
Contributor

jihoonson commented Apr 11, 2020

Hmm LGTM analysis failed. Is this a clean backport?

@himanshug
Copy link
Copy Markdown
Contributor Author

himanshug commented Apr 11, 2020

build passed in #9637 , I am looking at current failure.

@himanshug himanshug closed this Apr 11, 2020
@himanshug himanshug reopened this Apr 11, 2020
@himanshug
Copy link
Copy Markdown
Contributor Author

himanshug commented Apr 11, 2020

I have restarted the failed build... it says, "Running analyses for revisions.." now .. will see what that says on completion.

@jihoonson
Copy link
Copy Markdown
Contributor

jihoonson commented Apr 11, 2020

Oh hmm, I'm not sure LGTM is restarted by closing and reopening the PR. If you click "Details" button of failed LGTM, you can see the "re-run" button for it. I just restarted.

Screen Shot 2020-04-10 at 6 18 45 PM

@himanshug
Copy link
Copy Markdown
Contributor Author

himanshug commented Apr 11, 2020

thanks, yeah it appears to be running.

@jihoonson
Copy link
Copy Markdown
Contributor

jihoonson commented Apr 11, 2020

Oh the build failure seems legit.

[2020-04-11 01:24:04] [autobuild] [ERROR] Failed to execute goal on project druid-aws-common: Could not resolve dependencies for project org.apache.druid:druid-aws-common:jar:0.18.0-SNAPSHOT: Could not transfer artifact com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:jar:2.10.2 from/to central (https://repo.maven.apache.org/maven2): GET request of: com/fasterxml/jackson/dataformat/jackson-dataformat-cbor/2.10.2/jackson-dataformat-cbor-2.10.2.jar from central failed: Premature end of Content-Length delimited message body (expected: 58564; received: 0 -> [Help 1]
[2020-04-11 01:24:04] [autobuild] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project druid-aws-common: Could not resolve dependencies for project org.apache.druid:druid-aws-common:jar:0.18.0-SNAPSHOT: Could not transfer artifact com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:jar:2.10.2 from/to central (https://repo.maven.apache.org/maven2): GET request of: com/fasterxml/jackson/dataformat/jackson-dataformat-cbor/2.10.2/jackson-dataformat-cbor-2.10.2.jar from central failed

@himanshug
Copy link
Copy Markdown
Contributor Author

himanshug commented Apr 11, 2020

rerunning...

@himanshug
Copy link
Copy Markdown
Contributor Author

himanshug commented Apr 11, 2020

ok, LGTM is finally happy after 2 re-runs :)

@jihoonson
Copy link
Copy Markdown
Contributor

jihoonson commented Apr 11, 2020

Nice! @himanshug thank you for rerunning.

@jihoonson jihoonson merged commit 77ad2b1 into apache:0.18.0 Apr 11, 2020
@himanshug
Copy link
Copy Markdown
Contributor Author

himanshug commented Apr 11, 2020

@jihoonson thanks

@himanshug himanshug mentioned this pull request Apr 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Backport

Projects

None yet

Milestone

0.18.0

Development

Successfully merging this pull request may close these issues.

2 participants

@himanshug @jihoonson