Fix misuse of Integer.SIZE in FileWriteOutBytes.writeInt#9723
Merged
asdf2014 merged 2 commits intoapache:masterfrom Apr 19, 2020
Merged
Fix misuse of Integer.SIZE in FileWriteOutBytes.writeInt#9723asdf2014 merged 2 commits intoapache:masterfrom
asdf2014 merged 2 commits intoapache:masterfrom
Conversation
Member
|
@whutjs Please add a ASF license header to pass the CI. |
Contributor
|
We found this problem too and fix it in the pr #9722. After this pr is merged, I will change my commit. |
clintropolis
pushed a commit
to clintropolis/druid
that referenced
this pull request
Apr 22, 2020
* change Integer.SIZE to Integer.BYTES in FileWriteOutBytes#writeInt * Add ASF header Co-authored-by: jenson <junstan@paypal.com>
jihoonson
pushed a commit
that referenced
this pull request
Apr 24, 2020
JulianJaffePinterest
pushed a commit
to JulianJaffePinterest/druid
that referenced
this pull request
Jun 12, 2020
* change Integer.SIZE to Integer.BYTES in FileWriteOutBytes#writeInt * Add ASF header Co-authored-by: jenson <junstan@paypal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the
FileWriteOutBytes#writeInt(int)method, the argument passed toflushIfNeeded()isInteger.SIZEwhile theInteger.BYTESshould be used.Problem
This bug will incur one extra file write operation in some cases. For example, if we would like to write 4 KB of ints using
FileWriteOutBytes#writeInt(int), theflush()method will be called twice. After fixing this bug, theflush()method will be called only one.This PR has:
Key changed/added classes in this PR
FileWriteOutBytesFileWriteOutBytesTest