Skip to content

Removing null validation because a null check is not needed#3020

Merged
carryxyh merged 1 commit intoapache:masterfrom
sergioescala:null-validation-not-needed
Dec 20, 2018
Merged

Removing null validation because a null check is not needed#3020
carryxyh merged 1 commit intoapache:masterfrom
sergioescala:null-validation-not-needed

Conversation

@sergioescala
Copy link
Copy Markdown
Contributor

@sergioescala sergioescala commented Dec 19, 2018

Removing null validation because a null check is not needed before using instanceof

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@sergioescala sergioescala changed the title Removing null validation because a null check is not needed before us… Removing null validation because a null check is not needed Dec 19, 2018
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3020 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3020      +/-   ##
=========================================
+ Coverage   64.28%   64.3%   +0.01%     
=========================================
  Files         584     584              
  Lines       26056   26056              
  Branches     4562    4562              
=========================================
+ Hits        16751   16756       +5     
+ Misses       7123    7120       -3     
+ Partials     2182    2180       -2
Impacted Files Coverage Δ
...protocol/dubbo/status/ThreadPoolStatusChecker.java 0% <0%> (ø) ⬆️
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) ⬇️
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 67.77% <0%> (-2.23%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 60.86% <0%> (-2.18%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 60.62% <0%> (-1.75%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 80.07% <0%> (-1.51%) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 56.01% <0%> (-0.38%) ⬇️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 66.66% <0%> (+0.83%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 859efef...ffb9d42. Read the comment docs.

@carryxyh
Copy link
Copy Markdown
Member

LGTM.
Thx for your contribution!

@carryxyh carryxyh merged commit 1a06874 into apache:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants