Sankey chart: Nodes are not connected with edges after dragging

[paulputter]

Version

4.9.0

Reproduction link

https://echarts.apache.org/examples/en/editor.html?c=sankey-simple

Steps to reproduce

Change "series.data" array to "series.nodes" array.

What is expected?

Nodes and edges are connected while dragging the nodes

What is actually happening?

Dragging the nodes "disconnects" them from the edges

---

Error is in the setNodePosition function. It looks for option.data and not additionally for option.nodes:

setNodePosition: function (dataIndex, localPosition) {
    var dataItem = this.option.data[dataIndex];
    dataItem.localX = localPosition[0];
    dataItem.localY = localPosition[1];
  },

[echarts-bot]

Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.

In the meanwhile, please make sure that you have posted enough image to demo your request. You may also check out the API and chart option to get the answer.

If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.

If you are interested in the project, you may also subscribe our mailing list.

Have a nice day! 🍵

[echarts-bot]

This issue is labeled with difficulty: easy.
@paulputter Would you like to debug it by yourself? This is a quicker way to get your problem fixed. Or you may wait for the community to fix.

Please have a look at How to debug ECharts if you'd like to give a try. 🤓

[paulputter]

Sure, will do.

[paulputter]

Here's my fix:

setNodePosition(dataIndex: number, localPosition: number[]) {
        if (this.option.data) {
            const dataItem = this.option.data[dataIndex];
            dataItem.localX = localPosition[0];
            dataItem.localY = localPosition[1];
        } 
        else if (this.option.nodes) {
            const dataItem = this.option.nodes[dataIndex];
            dataItem.localX = localPosition[0];
            dataItem.localY = localPosition[1];
        }
}

[pissang]

It has been fixed in #15199