[Bug] legend.itemStyle.decal is invalid

[jouryfirst]

Version

5.2.1+

Link to Minimal Reproduction

https://echarts.apache.org/examples/zh/editor.html?c=doc-example/aria-pie&version=5.2.1

Steps to Reproduce

option = {
  aria: {
    enabled: true,
    decal: {
      show: true
    }
  },
  legend: {
    itemStyle: {
      decal: 'none'
    }
  },
  title: {
    text: '某站点用户访问来源',
    left: 'center'
  },
  series: [
    {
      name: '访问来源',
      type: 'pie',
      data: [
        { value: 335, name: '直接访问' },
        { value: 310, name: '邮件营销' },
        { value: 234, name: '联盟广告' },
        { value: 135, name: '视频广告' },
        { value: 1548, name: '搜索引擎' }
      ]
    }
  ]
};

Current Behavior

The docs say that while legend.itemStyle.decal is set to be 'none', no decal will be used.
I've set legend.itemStyle.decal to 'none', But the decal is still visible in V5.2.1+

Expected Behavior

as in the version 5.2.0, legend will be a solid color while legend.itemStyle.decal set 'none'

Environment

No response

Any additional comments?

No response

[echarts-bot]

@jouryfirst It seems you are not using English, I've helped translate the content automatically. To make your issue understood by more people and get helped, we'd like to suggest using English next time. 🤗

TRANSLATED

BODY

Version

5.2.1+

Link to Minimal Reproduction

https://echarts.apache.org/examples/en/editor.html?c=doc-example/aria-pie&version=5.2.1

Steps to Reproduce

option = {
aria: {
enabled: true
},
legend: {
itemStyle: {
decal: 'none'
}
},
title: {
text: 'A site's user access source',
left: 'center'
},
series: [
{
name: 'Access source',
type: 'pie',
data: [
{ value: 335, name: 'Direct access' },
{ value: 310, name: 'email marketing' },
{ value: 234, name: 'affiliate ad' },
{ value: 135, name: 'video ad' },
{ value: 1548, name: 'search engine' }
]
}
]
};

Current Behavior

The docs say that while legend.itemStyle.decal is set to be 'none', no decal will be used.
I've set legend.itemStyle.decal to 'none', But the decal is still visible in V5.2.1+

Expected Behavior

as in the version 5.2.0, legend will be a solid color while legend.itemStyle.decal set 'none'

Environment

No response

Any additional comments?

No response

[echarts-bot]

This issue is labeled with difficulty: easy.
@jouryfirst Would you like to debug it by yourself? This is a quicker way to get your problem fixed. Or you may wait for the community to fix.

Please have a look at How to debug ECharts if you'd like to give a try. 🤓

[jiawulin001]

Problem locating

In my opinion, the problem is here:

echarts/src/component/legend/LegendView.ts

Line 568 in 4a52199

itemStyle.decal = itemVisualStyle.decal;

legend.itemStyle.decal is directly overwritten by the series itemStyle. Also, the origin value of legend.itemStyle.decal is not passed in either because when echarts try getting items in legend.itemStyle here:

echarts/src/model/mixin/makeStyleMapper.ts

Line 46 in 4a52199

const val = model.getShallow(propName, ignoreParent);

decal is not included in the list of ITEM_STYLE_KEY_MAP:

echarts/src/model/mixin/itemStyle.ts

Lines 25 to 41 in 4a52199

	export const ITEM_STYLE_KEY_MAP = [
	['fill', 'color'],
	['stroke', 'borderColor'],
	['lineWidth', 'borderWidth'],
	['opacity'],
	['shadowBlur'],
	['shadowOffsetX'],
	['shadowOffsetY'],
	['shadowColor'],
	['lineDash', 'borderType'],
	['lineDashOffset', 'borderDashOffset'],
	['lineCap', 'borderCap'],
	['lineJoin', 'borderJoin'],
	['miterLimit', 'borderMiterLimit']
	// Option decal is in `DecalObject` but style.decal is in `PatternObject`.
	// So do not transfer decal directly.
	];

Plan to solve

So my plan to solve this is:

1. Add decal to the list of ITEM_STYLE_KEY_MAP (concern in comment is stated below)
2. Add a check if decal is none.

The comment here says

// Option decal is in `DecalObject` but style.decal is in `PatternObject`.
// So do not transfer decal directly.

But this is for reading what decal pattern is and here I am adding decal just to check if user sets it to 'none'. So I don't think it will affect decal in other places
Submitting a PR to solve this