fix(candlestick): fix overflow data access in tooltip.#15383
Merged
Conversation
|
Thanks for your contribution! The pull request is marked to be |
100pah
approved these changes
Jul 20, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Since the change in #15194. Candlestick tooltip will update when dataZoom is triggered. But because data may be empty after dataZoom and
getDataParamswill have undefinedvaluein this case, and user defined formatted may throw an error if they don't check if the value is undefined. So we need to add an extra check ifdataIndexis overflow.Also, this PR adds a test case for ecomfe/zrender#788