fix(line): normalize the infinite value when calculating the visual gradient.#15416
Merged
Conversation
…radient, resolves #15407.
|
Thanks for your contribution! The pull request is marked to be |
pissang
reviewed
Jul 27, 2021
pissang
approved these changes
Jul 27, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Resolves #15407. When
visualMapis enabled, the line color is unexpected.Fixed issues
Details
Before: What was the problem?
After: How is it fixed in this PR?
Revert the change brought by #14602 in
LineView.tsand normalize the infinite valueecharts/src/chart/line/LineView.ts
Line 246 in cf7c4ef
Misc
Related test cases or examples to use the new APIs
Please refer to
test/linear-gradient.html.Others
Merging options
Other information