Skip to content

fix(line): not stop existing expand animation when update. #15599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pissang merged 1 commit into from
Sep 2, 2021
Merged

fix(line): not stop existing expand animation when update. #15599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/chart/line/LineView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,9 +691,18 @@ class LineView extends ChartView {
}

// Update clipPath
lineGroup.setClipPath(
createLineClipPath(this, coordSys, false, seriesModel)
);
const oldClipPath = lineGroup.getClipPath();
if (oldClipPath) {
const newClipPath = createLineClipPath(this, coordSys, false, seriesModel);
graphic.initProps(oldClipPath, {
shape: newClipPath.shape
}, seriesModel);
}
else {
lineGroup.setClipPath(
createLineClipPath(this, coordSys, true, seriesModel)
);
}

// Always update, or it is wrong in the case turning on legend
// because points are not changed
Expand Down
38 changes: 38 additions & 0 deletions test/line-animation.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.