Skip to content

fix(polar): fix edge symbols are clipped unexpectedly for the tiny offset. #16329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pissang merged 2 commits into from
Jan 6, 2022
Merged

fix(polar): fix edge symbols are clipped unexpectedly for the tiny offset. #16329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f078c62
fix(polar): fix symbols are clipped unexpectedly for the tiny offset.
plainheart Jan 5, 2022
f64d1eb
test: tweak test title.
plainheart Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/coord/polar/Polar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,8 @@ class Polar implements CoordinateSystem, CoordinateSystemMaster {
// Start angle and end angle don't matter
const dx = x - this.cx;
const dy = y - this.cy;
const d2 = dx * dx + dy * dy;
// minus a tiny value 1e-4 to avoid being clipped unexpectedly
const d2 = dx * dx + dy * dy - 1e-4;
const r = this.r;
const r0 = this.r0;

Expand Down Expand Up @@ -265,4 +266,4 @@ interface PolarArea extends CoordinateSystemClipArea {
clockwise: boolean
}

export default Polar;
export default Polar;
15 changes: 14 additions & 1 deletion test/clip.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.