Skip to content

fix(labelLine): update labelLine ignore #16542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pissang merged 3 commits into from
Mar 24, 2022
Merged

fix(labelLine): update labelLine ignore #16542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61ef71c
fix(labelLine): update labelLine `ignore`
susiwen8 Feb 18, 2022
d5e4469
Merge branch 'master' into fix-16539
susiwen8 Mar 24, 2022
291bf29
fix(labelLine): use correct state name
susiwen8 Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/label/labelGuideHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ export function setLabelLineStyle(
if (isLabelIgnored // Not show when label is not shown in this state.
|| !retrieve2(stateShow, showNormal) // Use normal state by default if not set.
) {
const stateObj = isNormal ? labelLine : (labelLine && labelLine.states.normal);
const stateObj = isNormal ? labelLine : (labelLine && labelLine.states[stateName]);
if (stateObj) {
stateObj.ignore = true;
}
Expand Down
59 changes: 59 additions & 0 deletions test/pie-label.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.