Skip to content

fix(sanky):fallback to black if color were illegal#16614

Merged
pissang merged 2 commits into
apache:masterfrom
susiwen8:16574
Mar 3, 2022
Merged

fix(sanky):fallback to black if color were illegal#16614
pissang merged 2 commits into
apache:masterfrom
susiwen8:16574

Conversation

@susiwen8
Copy link
Copy Markdown
Contributor

@susiwen8 susiwen8 commented Mar 2, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

if zrColor.parse returns undefiend, use #000 as default color

Fixed issues

Details

Before: What was the problem?

Screen Shot 2022-03-02 at 10 31 52 PM

After: How is it fixed in this PR?

Screen Shot 2022-03-02 at 10 31 19 PM

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Mar 2, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Comment thread src/visual/VisualMapping.ts Outdated
@susiwen8 susiwen8 requested a review from pissang March 2, 2022 15:02
@pissang pissang added this to the 5.3.2 milestone Mar 3, 2022
@pissang pissang merged commit e785e61 into apache:master Mar 3, 2022
@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Mar 3, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@susiwen8 susiwen8 deleted the 16574 branch March 3, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

桑基图option.color设置为数组,数组中颜色为空字符串时,报错

2 participants