Skip to content

feat(event-tree): add collapsed to tree click event parameters#16660

Merged
pissang merged 3 commits into
apache:masterfrom
susiwen8:16650
Mar 11, 2022
Merged

feat(event-tree): add collapsed to tree click event parameters#16660
pissang merged 3 commits into
apache:masterfrom
susiwen8:16650

Conversation

@susiwen8
Copy link
Copy Markdown
Contributor

@susiwen8 susiwen8 commented Mar 9, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Add isExpand to tree click event callback

Fixed issues

Details

Before: What was the problem?

After: How is it fixed in this PR?

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Mar 9, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@susiwen8 susiwen8 changed the title feat(event-tree): add isExpand to click cb feat(event-tree): add isExpand to tree click cb Mar 9, 2022
Comment thread src/chart/tree/TreeSeries.ts Outdated
@susiwen8 susiwen8 requested a review from pissang March 11, 2022 02:17
@pissang pissang changed the title feat(event-tree): add isExpand to tree click cb feat(event-tree): add collapsed to tree click event parameters Mar 11, 2022
Comment thread src/chart/tree/TreeSeries.ts Outdated
@susiwen8 susiwen8 requested a review from pissang March 11, 2022 02:51
@pissang pissang added this to the 5.3.2 milestone Mar 11, 2022
@pissang pissang merged commit 9c0c991 into apache:master Mar 11, 2022
@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Mar 11, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@susiwen8 susiwen8 deleted the 16650 branch March 11, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

isExpand or isCollapse flag missing in treechart

2 participants