Skip to content

feat: allow areaStyle.origin to take number as input #16719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pissang merged 2 commits into from
Mar 24, 2022
Merged

feat: allow areaStyle.origin to take number as input #16719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48472ee
feat: allow areaStyle.origin to take number as input
jiawulin001 Mar 22, 2022
0e5e896
An example of origin Updated
jiawulin001 Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/chart/line/LineSeries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export interface LineSeriesOption extends SeriesOption<LineStateOption<CallbackD
lineStyle?: LineStyleOption

areaStyle?: AreaStyleOption & {
origin?: 'auto' | 'start' | 'end'
origin?: 'auto' | 'start' | 'end' | number
}

step?: false | 'start' | 'end' | 'middle'
Expand Down
7 changes: 6 additions & 1 deletion src/chart/line/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/

import {isDimensionStacked} from '../../data/helper/dataStackHelper';
import {map} from 'zrender/src/core/util';
import {isNumber, map} from 'zrender/src/core/util';
import type Polar from '../../coord/polar/Polar';
import type Cartesian2D from '../../coord/cartesian/Cartesian2D';
import SeriesData from '../../data/SeriesData';
Expand Down Expand Up @@ -90,6 +90,11 @@ function getValueStart(valueAxis: Axis, valueOrigin: LineSeriesOption['areaStyle
else if (valueOrigin === 'end') {
valueStart = extent[1];
}
// If origin is specified as a number, use it as
// valueStart directly
else if (isNumber(valueOrigin) && !isNaN(valueOrigin)){
valueStart = valueOrigin;
}
// auto
else {
// Both positive
Expand Down
180 changes: 180 additions & 0 deletions test/area-origin.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.