fix(time): Quarters split the year into 4 quarters not 3. close #17057#17073
Merged
Conversation
|
Thanks for your contribution! |
Contributor
|
Could you remove unnecessary binary file? |
Ovilia
approved these changes
May 20, 2022
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
The quarter format would only go up to Q3 with each quarter having 3 months in them (not the current 4)
Fixed issues
Details
Before: What was the problem?
{q} would return 1 for Jan, Feb, Mar, Apr, 2 for May, Jun, July, Aug, 3 for Sep, Oct, Nov, Dec
After: How is it fixed in this PR?
{q} will return 1 for Jan, Feb, Mar, 2 for Apr, May, Jun, 3 for July, Aug, Sep, 4 for Oct, Nov, Dec
Misc
close [Bug] Quarter in date format returns only up to Quarter 3 #17057
The API has been changed (apache/echarts-doc#xxx).
This PR depends on ZRender changes (ecomfe/zrender#xxx).
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information