Skip to content

fix(marker): fix markArea doesn't show when using x/y pixel but coord is not defined#17217

Merged
plainheart merged 4 commits into
apache:masterfrom
jiawulin001:issue#10074
Nov 11, 2022
Merged

fix(marker): fix markArea doesn't show when using x/y pixel but coord is not defined#17217
plainheart merged 4 commits into
apache:masterfrom
jiawulin001:issue#10074

Conversation

@jiawulin001
Copy link
Copy Markdown
Member

@jiawulin001 jiawulin001 commented Jun 15, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix the error that occurs when declaring area with x/y in markArea

Fixed issues

Details

Before: What was the problem?

As is described in issues, when setting x and y to denote an area for markArea, the error occurs. This is caused becasue lt and rb returned by dataTransform() has no attribute coord when user does not specify coord in markArea.data. So when running the following code, Echarts reads lt.coord and throw an error.

const lt = markerHelper.dataTransform(seriesModel, item[0]);
const rb = markerHelper.dataTransform(seriesModel, item[1]);
// FIXME make sure lt is less than rb
const ltCoord = lt.coord;
const rbCoord = rb.coord;
ltCoord[0] = retrieve(ltCoord[0], -Infinity);
ltCoord[1] = retrieve(ltCoord[1], -Infinity);
rbCoord[0] = retrieve(rbCoord[0], Infinity);
rbCoord[1] = retrieve(rbCoord[1], Infinity);

image

After: How does it behave after the fixing?

Now before dataTransform() return an item, a check is added and make sure there's a coord attribute in it (even coord is not needed). And there will be no errors caused by this.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Jun 15, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Comment thread src/component/marker/markerHelper.ts
@plainheart plainheart changed the title fix: fix the error caused by setting markArea x/y fix(marker): fix markArea doesn't show when using x/y pixel but coord is not defined Nov 10, 2022
Copy link
Copy Markdown
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plainheart plainheart merged commit 34a8fca into apache:master Nov 11, 2022
@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Nov 11, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] that cannot be rendered normally when makearea data is the scale field between two screen coordinates

3 participants