fix(marker): fix markArea doesn't show when using x/y pixel but coord is not defined#17217
Merged
Conversation
|
Thanks for your contribution! |
Ovilia
requested changes
Sep 23, 2022
markArea doesn't show when using x/y pixel but coord is not defined
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix the error that occurs when declaring area with x/y in
markAreaFixed issues
Details
Before: What was the problem?
As is described in issues, when setting x and y to denote an area for
markArea, the error occurs. This is caused becasueltandrbreturned bydataTransform()has no attributecoordwhen user does not specifycoordinmarkArea.data. So when running the following code, Echarts readslt.coordand throw an error.echarts/src/component/marker/MarkAreaView.ts
Lines 69 to 79 in 11a9247
After: How does it behave after the fixing?
Now before
dataTransform()return anitem, a check is added and make sure there's acoordattribute in it (evencoordis not needed). And there will be no errors caused by this.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information