perf(pie): optimize performance of pie series#17275
Merged
Merged
Conversation
|
Thanks for your contribution! |
Ovilia
requested changes
Jun 24, 2022
Contributor
Ovilia
left a comment
Ovilia
left a comment
There was a problem hiding this comment.
Please first add a test case by npm run mktest pie-percent to serve as benchmark to see how much improvement this PR makes.
wind108369
force-pushed
the
improve-pie-performance
branch
from
881caf3 to
558acc1
Compare
Contributor
Author
|
1000个数据点，pie-percent.html中的数据，优化前 优化后 |
pissang
reviewed
Jun 29, 2022
wind108369
force-pushed
the
improve-pie-performance
branch
2 times, most recently
from
8487163 to
3d6ec90
Compare
plainheart
reviewed
Jul 4, 2022
wind108369
force-pushed
the
improve-pie-performance
branch
from
3d6ec90 to
55a9f77
Compare
plainheart
reviewed
Jul 4, 2022
wind108369
force-pushed
the
improve-pie-performance
branch
from
55a9f77 to
8afad04
Compare
plainheart
approved these changes
Jul 4, 2022
Member
plainheart
left a comment
plainheart
left a comment
There was a problem hiding this comment.
LGTM. The optimization for the performance of the pie series looks quite significant!
plainheart
requested changes
Aug 4, 2022
plainheart
reviewed
Aug 4, 2022
wind108369
force-pushed
the
improve-pie-performance
branch
from
8afad04 to
08a8ad7
Compare
wind108369
force-pushed
the
improve-pie-performance
branch
from
08a8ad7 to
6e617f2
Compare
plainheart
reviewed
Aug 4, 2022
wind108369
force-pushed
the
improve-pie-performance
branch
from
6e617f2 to
15edecf
Compare
plainheart
reviewed
Aug 4, 2022
wind108369
force-pushed
the
improve-pie-performance
branch
from
15edecf to
3a6c097
Compare
plainheart
approved these changes
Aug 4, 2022
Member
plainheart
left a comment
plainheart
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Ovilia
approved these changes
Aug 4, 2022
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
饼图现在的渲染有性能问题，
getPercentWithPrecision是很消耗性能的方法，每一个数据项都需要执行一次，在 10000 个数据点的时候就能把页面卡死，可以总的执行一次再取数使用。Fixed issues
Fixes #17173
Details
Before: What was the problem?
After: How does it behave after the fixing?
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information
没有删掉getPercentWithPrecision，因为api里面有暴露给外包
测试之前需要执行 prepublish