Skip to content

chore: fix wrong imports from echarts.all #17452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ovilia merged 2 commits into from
Aug 2, 2022
Merged

chore: fix wrong imports from echarts.all #17452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59e180e
chore: fix wrong imports from `echarts.all`
plainheart Aug 1, 2022
e3c8e3c
chore: fix wrong imports from `echarts.all`
plainheart Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/animation/customGraphicKeyframeAnimation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import Element from 'zrender/src/Element';
import { keys, filter, each, isArray, indexOf } from 'zrender/src/core/util';
import { ELEMENT_ANIMATABLE_PROPS } from './customGraphicTransition';
import { AnimationOption, AnimationOptionMixin, Dictionary } from '../util/types';
import { Model } from '../echarts.all';
import type Model from '../model/Model';
import { getAnimationConfig } from './basicTransition';
import { warn } from '../util/log';
import { makeInner } from '../util/model';
Expand Down Expand Up @@ -159,4 +159,4 @@ export function applyKeyframeAnimation<T extends Record<string, any>>(
.duration(duration)
.start(animationOpts.easing);
});
}
}
2 changes: 1 addition & 1 deletion src/chart/custom/CustomView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ import {
applyKeyframeAnimation,
stopPreviousKeyframeAnimationAndRestore
} from '../../animation/customGraphicKeyframeAnimation';
import { SeriesModel } from '../../echarts.all';
import type SeriesModel from '../../model/Series';

const EMPHASIS = 'emphasis' as const;
const NORMAL = 'normal' as const;
Expand Down
9 changes: 4 additions & 5 deletions src/coord/geo/geoCreator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,14 @@ import MapSeries, { MapSeriesOption } from '../../chart/map/MapSeries';
import ExtensionAPI from '../../core/ExtensionAPI';
import { CoordinateSystemCreator } from '../CoordinateSystem';
import { NameMap } from './geoTypes';
import SeriesModel from '../../model/Series';
import { SeriesOption, SeriesOnGeoOptionMixin } from '../../util/types';
import { Dictionary } from 'zrender/src/core/types';
import GlobalModel from '../../model/Global';
import ComponentModel from '../../model/Component';
import { Model } from '../../echarts.all';
import type Model from '../../model/Model';
import type GlobalModel from '../../model/Global';
import type SeriesModel from '../../model/Series';
import type ComponentModel from '../../model/Component';
import * as vector from 'zrender/src/core/vector';


export type resizeGeoType = typeof resizeGeo;

/**
Expand Down