Skip to content

fix(legend): fix legend inverse doesn't work if series data have the same name #17510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ovilia merged 2 commits into from
Sep 22, 2022
Merged

fix(legend): fix legend inverse doesn't work if series data have the same name #17510

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fe4561
fix: remove legend name duplicate to prevent double inverse bug
Aug 14, 2022
46cdb2b
fix: revert package-lock.json
Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/component/legend/LegendModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,21 +354,27 @@ class LegendModel<Ops extends LegendOption = LegendOption> extends ComponentMode
// which is convinient for user preparing option.
const rawData = this.get('data') || potentialData;

const legendNameMap = zrUtil.createHashMap();
const legendData = zrUtil.map(rawData, function (dataItem) {
// Can be string or number
if (zrUtil.isString(dataItem) || zrUtil.isNumber(dataItem)) {
dataItem = {
name: dataItem as string
};
}
if (legendNameMap.get(dataItem.name)) {
// remove legend name duplicate
return null;
}
legendNameMap.set(dataItem.name, true);
return new Model(dataItem, this, this.ecModel);
}, this);

/**
* @type {Array.<module:echarts/model/Model>}
* @private
*/
this._data = legendData;
this._data = zrUtil.filter(legendData, item => !!item);
}

getData() {
Expand Down