Skip to content

fix(type): add missing function callback into lineStyle.color for lines series. #17780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plainheart merged 1 commit into from
Nov 13, 2022
Merged

fix(type): add missing function callback into lineStyle.color for lines series. #17780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/chart/lines/LinesSeries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ export interface LinesStateOption<TCbParams = never> {
label?: SeriesLineLabelOption
}

export interface LinesDataItemOption extends LinesStateOption<CallbackDataParams>,
StatesOptionMixin<LinesStateOption<CallbackDataParams>, LinesStatesMixin> {
export interface LinesDataItemOption extends LinesStateOption,
StatesOptionMixin<LinesStateOption, LinesStatesMixin> {
name?: string

fromName?: string
Expand All @@ -111,7 +111,7 @@ export interface LinesDataItemOption extends LinesStateOption<CallbackDataParams
}

export interface LinesSeriesOption
extends SeriesOption<LinesStateOption, LinesStatesMixin>, LinesStateOption,
extends SeriesOption<LinesStateOption, LinesStatesMixin>, LinesStateOption<CallbackDataParams>,
SeriesOnCartesianOptionMixin, SeriesOnGeoOptionMixin, SeriesOnPolarOptionMixin,
SeriesOnCalendarOptionMixin, SeriesLargeOptionMixin {

Expand Down
4 changes: 2 additions & 2 deletions src/chart/lines/LinesView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class LinesView extends ChartView {

const lineDraw = this._updateLineDraw(data, seriesModel);

lineDraw.incrementalPrepareUpdate(data);
lineDraw.incrementalPrepareUpdate(data as any);

this._clearLayer(api);

Expand All @@ -118,7 +118,7 @@ class LinesView extends ChartView {
seriesModel: LinesSeriesModel,
ecModel: GlobalModel
) {
this._lineDraw.incrementalUpdate(taskParams, seriesModel.getData());
this._lineDraw.incrementalUpdate(taskParams, seriesModel.getData() as any);

this._finished = taskParams.end === seriesModel.getData().count();
}
Expand Down