fix(data): change deprecated map.data.hasOwnProperty to map.hasKey#17861
Merged
Conversation
…der#966, change `hasOwnProperty` to `hasKey`.
|
Thanks for your contribution! The pull request is marked to be This PR depends on ZRender changes. Please update the ZRender dependency to the latest nightly version including this change, which takes place everyday at 8:00 UTC (16:00 Beijing Time). |
pissang
approved these changes
Nov 6, 2022
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
ecomfe/zrender#966 has refactored the HashMap, which prefers the native built-in
Map. It causes theHashMap.data.hasOwnPropertyto be not working. So this PR is to change it tomap.hasKey.Fixed issues
Fix failed unit test
test/ut/spec/data/createDimensions.test.tsFailed information: https://github.com/apache/echarts/actions/runs/3368150373/jobs/5586364387
Document Info
One of the following should be checked.
Misc
ZRender Changes
hasKeymethod intoHashMapfor ECharts. ecomfe/zrender#971).Related test cases or examples to use the new APIs
Please refer to
test/ut/spec/data/createDimensions.test.tsOthers
Merging options
Other information