Skip to content

style: fix code style flaw and remove unnecessary default parameter.#17887

Merged
Ovilia merged 1 commit into
masterfrom
fix/code-style-17098
Nov 8, 2022
Merged

style: fix code style flaw and remove unnecessary default parameter.#17887
Ovilia merged 1 commit into
masterfrom
fix/code-style-17098

Conversation

@plainheart
Copy link
Copy Markdown
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  • Remove unnecessary default value false for the parameter startingAtTick to avoid extra code after compilation.
  • Fix some code style flaws in the source and test case.

Fixed issues

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Nov 8, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart requested a review from Ovilia November 8, 2022 06:07
@plainheart plainheart force-pushed the fix/code-style-17098 branch from b9a19eb to 63dd98a Compare November 8, 2022 06:10
@Ovilia Ovilia merged commit 7fe9b73 into master Nov 8, 2022
@Ovilia Ovilia deleted the fix/code-style-17098 branch November 8, 2022 06:40
@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Nov 8, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants