Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/component/axis/AxisBuilder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ class AxisBuilder {
);


// FIXME Not use a seperate text group?
// FIXME Not use a separate text group?
const transformGroup = new graphic.Group({
x: opt.position[0],
y: opt.position[1],
Expand Down Expand Up @@ -796,7 +796,7 @@ function buildAxisLabel(
// in category axis.
// (2) Compatible with previous version, which always use formatted label as
// input. But in interval scale the formatted label is like '223,445', which
// maked user repalce ','. So we modify it to return original val but remain
// maked user replace ','. So we modify it to return original val but remain
// it as 'string' to avoid error in replacing.
axis.type === 'category'
? rawLabel
Expand Down
8 changes: 4 additions & 4 deletions src/component/transform/filterTransform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ export const filterTransform: ExternalDataTransform<FilterTransformOption> = {

type: 'echarts:filter',

// PEDING: enhance to filter by index rather than create new data
// PENDING: enhance to filter by index rather than create new data
transform: function (params) {
// [Caveat] Fail-Fast:
// Do not return the whole dataset unless user config indicate it explicitly.
// For example, if no condition specified by mistake, return an empty result
// is better than return the entire raw soruce for user to find the mistake.
// Do not return the whole dataset unless user config indicates it explicitly.
// For example, if no condition is specified by mistake, returning an empty result
// is better than returning the entire raw source for the user to find the mistake.

const upstream = params.upstream;
let rawItem: DataTransformDataItem;
Expand Down
2 changes: 1 addition & 1 deletion src/model/Series.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ class SeriesModel<Opt extends SeriesOption = SeriesOption> extends ComponentMode
// @readonly
seriesIndex: number;

// coodinateSystem will be injected in the echarts/CoordinateSystem
// coordinateSystem will be injected in the echarts/CoordinateSystem
coordinateSystem: CoordinateSystem;

// Injected outside
Expand Down