Skip to content

fix: update example#18115

Merged
plainheart merged 1 commit into
apache:masterfrom
huangyulie:fix-auto-huangyulie
Dec 28, 2022
Merged

fix: update example#18115
plainheart merged 1 commit into
apache:masterfrom
huangyulie:fix-auto-huangyulie

Conversation

@huangyulie
Copy link
Copy Markdown
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Update examples
the warning!
bfb1ecd6bd986a449116b759c57886f
the Official interpretation:
image
However, the examples in ecrarts still has the auto attribute
https://echarts.apache.org/examples/zh/editor.html?c=gauge-multi-title
image

Fixed issues

Details

Before: What was the problem?

the examples in ecrarts still have the auto attribute
Warning!

After: How does it behave after the fixing?

No warning

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Dec 27, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

Copy link
Copy Markdown
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting the deprecated usage. If you'd like to update them for the examples, you may go to the apache/echarts-examples repo.

The source code of the examples is placed in the public/examples/ts folder.
e.g. https://github.com/apache/echarts-examples/blob/gh-pages/public/examples/ts/gauge-multi-title.ts

@plainheart plainheart merged commit 843c1e8 into apache:master Dec 28, 2022
@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Dec 28, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants