Ignore files about 'contributing' when publish to npm#18301
Merged
Conversation
|
Thanks for your contribution! |
plainheart
requested changes
Feb 23, 2023
Member
plainheart
left a comment
plainheart
left a comment
There was a problem hiding this comment.
Thanks for your suggestion! But we can't directly remove the file. It's better to ignore this file when publishing to npm. Just add this file to .npmignore.
fullmooooon
changed the title
Contributor
Author
|
@plainheart Thank you for your suggestion. It has been revised. |
plainheart
reviewed
Feb 23, 2023
fullmooooon
changed the title
plainheart
approved these changes
Feb 23, 2023
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed issues
Details
I found this PNG in my "node_modules\echarts" folder. I checked it in the repository. This PNG is not associated with any files in the current code base. Although this 235 KB image only accounts for 0.5% of the entire folder, it is unreasonable to add extra useless files on thousands of front-end developers' computers
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information