Skip to content

chore: update jest-canvas-mock to fix test fails in node v18#18538

Merged
pissang merged 2 commits into
masterfrom
fix/jest-canvas-mock
Apr 23, 2023
Merged

chore: update jest-canvas-mock to fix test fails in node v18#18538
pissang merged 2 commits into
masterfrom
fix/jest-canvas-mock

Conversation

@plainheart
Copy link
Copy Markdown
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

The unit test always fails in node v18 due to the jest-canvas-mock dependency.

As per the release note, it has been fixed since v2.4.0. See also hustcc/jest-canvas-mock#91

@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Apr 20, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

@plainheart plainheart force-pushed the fix/jest-canvas-mock branch from b87b6dd to 5fd7a07 Compare April 20, 2023 10:45
@plainheart plainheart requested review from pissang and removed request for pissang April 20, 2023 10:49
@pissang pissang merged commit d7ac6c3 into master Apr 23, 2023
@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Apr 23, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants