Skip to content

feat(axis): enale boundaryGap for category axis #19638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xdbobname wants to merge 2 commits into from
Closed

feat(axis): enale boundaryGap for category axis #19638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2821dbe
feat(axis): enale boundaryGap for category axis
Feb 22, 2024
f46ec56
feat(axis): enable boundaryGap for category axis
Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/coord/Axis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* under the License.
*/

import {each, map} from 'zrender/src/core/util';
import {each, isArray, map} from 'zrender/src/core/util';
import {linearMap, getPixelPrecision, round} from '../util/number';
import {
createAxisTicks,
Expand Down Expand Up @@ -126,7 +126,7 @@ class Axis {

if (this.onBand && scale.type === 'ordinal') {
extent = extent.slice() as [number, number];
fixExtentWithBands(extent, (scale as OrdinalScale).count());
fixExtentWithBands(extent, (scale as OrdinalScale).count(), isArray(this.onBand) ? this.onBand : []);
}

return linearMap(data, NORMALIZED_EXTENT, extent, clamp);
Expand Down Expand Up @@ -271,12 +271,12 @@ class Axis {

}

function fixExtentWithBands(extent: [number, number], nTick: number): void {
function fixExtentWithBands(extent: [number, number], nTick: number, onBand: number[] = []): void {
const size = extent[1] - extent[0];
const len = nTick;
const margin = size / len / 2;
extent[0] += margin;
extent[1] -= margin;
extent[0] += onBand[0] || margin;
extent[1] -= onBand[1] || margin;
}

// If axis has labels [1, 2, 3, 4]. Bands on the axis are
Expand Down
93 changes: 93 additions & 0 deletions test/line-space-between.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.