Skip to content

chore(workflow): use forked workflow deps for timely update #20051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ovilia merged 1 commit into from
Jun 20, 2024
Merged

chore(workflow): use forked workflow deps for timely update #20051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/pr-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ jobs:
return jobsRes.data.jobs.some((job) => job.name.includes('build') && job.conclusion === 'success');

outputs:
SHOULD_DEPOLY: ${{ steps.check-build-success.outputs.result }}
SHOULD_DEPLOY: ${{ steps.check-build-success.outputs.result }}

deploy:
needs: [on-success]
if: ${{ needs.on-success.outputs.SHOULD_DEPOLY == 'true' }}
if: ${{ needs.on-success.outputs.SHOULD_DEPLOY == 'true' }}
runs-on: ubuntu-latest

steps:
Expand All @@ -38,7 +38,7 @@ jobs:
mkdir .actions
cd .actions
git clone --depth=1 https://github.com/dawidd6/action-download-artifact.git
git clone --depth=1 https://github.com/actions-cool/maintain-one-comment.git
git clone --depth=1 https://github.com/plainheart/maintain-one-comment.git

- name: Fetch PR dist files
uses: ./.actions/action-download-artifact
Expand Down Expand Up @@ -70,7 +70,6 @@ jobs:
COMMIT_SHA_SHORT: ${{ steps.pr-metadata.outputs.COMMIT_SHA_SHORT }}
with:
body: |
<!-- ECHARTS_PR_PREVIEW -->
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-${{ env.PR_NUMBER }}@${{ env.COMMIT_SHA_SHORT }}
body-include: '<!-- ECHARTS_PR_PREVIEW -->'
number: ${{ env.PR_NUMBER }}
2 changes: 1 addition & 1 deletion .github/workflows/teardown-pr-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Install action dependencies
run: git clone --depth=1 https://github.com/actions-cool/maintain-one-comment.git
run: git clone --depth=1 https://github.com/plainheart/maintain-one-comment.git

- name: Delete PR preview comment
uses: ./maintain-one-comment
Expand Down