Skip to content

fix(series): mismatched dimension index when canOmitUnusedDimensions is true #20682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
100pah merged 2 commits into from
Mar 6, 2025
Merged

fix(series): mismatched dimension index when canOmitUnusedDimensions is true #20682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c737464
fix(series): mismatched dimension index when canOmitUnusedDimensions …
Jan 13, 2025
5bb0785
test(series):mismatched dimension index when canOmitUnusedDimensions …
Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/data/SeriesData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,11 +316,16 @@ class SeriesData<
if (dimensionInfo.createInvertedIndices) {
invertedIndicesMap[dimensionName] = [];
}

let dimIdx = i;
if (zrUtil.isNumber(dimensionInfo.storeDimIndex)) {
dimIdx = dimensionInfo.storeDimIndex;
}
Comment on lines +321 to +323
Copy link
Copy Markdown
Member

@plainheart plainheart Dec 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to lead a regression issue described in #21415. I would suggest fixing it in v6.1.0.

if (otherDims.itemName === 0) {
this._nameDimIdx = i;
this._nameDimIdx = dimIdx;
}
if (otherDims.itemId === 0) {
this._idDimIdx = i;
this._idDimIdx = dimIdx;
}

if (__DEV__) {
Expand Down
1 change: 1 addition & 0 deletions test/runTest/actions/__meta__.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions test/runTest/actions/series-omitUnusedDimensions.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

221 changes: 221 additions & 0 deletions test/series-omitUnusedDimensions.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.