Skip to content

fix(axis): fix chart does not work when using customValues with formatter in time axis label #21352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plainheart merged 2 commits into from
Nov 14, 2025
+60 −3
Merged

fix(axis): fix chart does not work when using customValues with formatter in time axis label #21352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3010cb8
fix(time-axis): resolve TypeError when using customValues with format…
Srajan-Sanjay-Saxena Nov 12, 2025
e9b24db
test: add customValues with formatter test case to axis-customTicks.html
Srajan-Sanjay-Saxena Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/scale/Time.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,10 @@ class TimeScale extends IntervalScale<TimeScaleSetting> {
let upperUnitIndex = primaryTimeUnits.length - 1;
let maxLevel = 0;
each(ticks, tick => {
upperUnitIndex = Math.min(upperUnitIndex, indexOf(primaryTimeUnits, tick.time.upperTimeUnit));
maxLevel = Math.max(maxLevel, tick.time.level);
if (tick.time) {
Copy link
Copy Markdown
Member

@plainheart plainheart Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that TypeScript suppresses this TypeError as per the current tsconfig.json, where the strictNullChecks option is disabled. But if we enable it, there are many errors to be fixed. For simplicity, I agree with your current fix by adding the safeguard.

@100pah How do you think about this?

upperUnitIndex = Math.min(upperUnitIndex, indexOf(primaryTimeUnits, tick.time.upperTimeUnit));
maxLevel = Math.max(maxLevel, tick.time.level);
}
});

if (scaleBreakHelper) {
Expand Down
2 changes: 1 addition & 1 deletion src/util/time.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ export function leveledFormat(
else if (zrUtil.isFunction(formatter)) {
const extra: TimeAxisLabelFormatterExtraParams = {
time: tick.time,
level: tick.time.level,
level: tick.time ? tick.time.level : 0,
};
const scaleBreakHelper = getScaleBreakHelper();
if (scaleBreakHelper) {
Expand Down
55 changes: 55 additions & 0 deletions test/axis-customTicks.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.