fix(scatter): fix jitter layout does not support progressive rendering and cause chart to freeze and potential NPE#21436
Merged
Merged
Conversation
…g and causes chart to stuck and potential NPE
echarts-bot
Bot
added
PR: author is committer
PR: awaiting review
PR: doc unchanged
labels
|
Thanks for your contribution! The pull request is marked to be |
plainheart
commented
Dec 18, 2025
Comment on lines
+70
to
+82
| if (!(jitter > 0)) { | ||
| return floatCoord; | ||
| } | ||
| const jitterOverlap = axisModel.get('jitterOverlap'); | ||
| const jitterMargin = axisModel.get('jitterMargin') || 0; | ||
| // Get band width to limit jitter range | ||
| const bandWidth = fixedAxis.scale.type === 'ordinal' | ||
| ? fixedAxis.getBandWidth() | ||
| : null; | ||
| if (jitter > 0) { | ||
| if (jitterOverlap) { | ||
| return fixJitterIgnoreOverlaps(floatCoord, jitter, bandWidth, radius); | ||
| } | ||
| else { | ||
| return fixJitterAvoidOverlaps(fixedAxis, fixedCoord, floatCoord, radius, jitter, jitterMargin); | ||
| } | ||
| if (jitterOverlap) { | ||
| return fixJitterIgnoreOverlaps(floatCoord, jitter, bandWidth, radius); | ||
| } | ||
| return floatCoord; | ||
| return fixJitterAvoidOverlaps(fixedAxis, fixedCoord, floatCoord, radius, jitter, jitterMargin); |
Member
Author
There was a problem hiding this comment.
No logical bug here. Just tweaked the code style.
Contributor
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21436@5592113 |
100pah
approved these changes
Dec 20, 2025
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Current implementation of
scatterJitterLayoutdoes not support progressive rendering likescatterPointsLayout, which causes two issues:seriesData.getItemLayout(idx)Please take a look at this online example for a quick view.
Fixed issues
Comparison
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/scatter-jitter.html.test/scatter-weibo.htmltest/scatter-stream-large.htmltest/scatter-random-stream.htmlMerging options
Other information