[ISSUE #3879] Logger of slf4j does not work in eventmesh-common test module#3882
Closed
pandaapo wants to merge 3 commits intoapache:masterfrom
Closed
[ISSUE #3879] Logger of slf4j does not work in eventmesh-common test module#3882pandaapo wants to merge 3 commits intoapache:masterfrom
pandaapo wants to merge 3 commits intoapache:masterfrom
Conversation
pandaapo
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3882 +/- ##
============================================
- Coverage 14.24% 13.94% -0.30%
+ Complexity 1320 1291 -29
============================================
Files 579 570 -9
Lines 28967 28847 -120
Branches 2802 2811 +9
============================================
- Hits 4125 4024 -101
Misses 24450 24450
+ Partials 392 373 -19 see 145 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
Can we only add a xml configuration file under this module? This PR #4719 proposes an alternative way to manage the Slf4j dependency, and let's looking forward to it. |
Pil0tXia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3879.
Motivation
The object of
org.slf4j.Loggercan not execute no matterlog.info,log.errorand so on in test.Modifications
Add log4j2.xml to eventmesh-common test module
Documentation