mojaloop-fineract integration 1.0#544
Closed
marta-jankovics wants to merge 5 commits into
Closed
Conversation
vishwasbabu
requested changes
Mar 11, 2019
Member
vishwasbabu
left a comment
vishwasbabu
left a comment
There was a problem hiding this comment.
@marta-jankovics : Thanks for your pr :)
A Fineract committer would review and provide feedback / merge the same once you have checked off on each item of the checklist associated with the PR and confirmed that the Travis build has completed successfully on your PR.
|
@vishwasbabu |
Member
@fonlawrence : Apologies, I missed responding to you earlier. Here's one https://jira.apache.org/jira/browse/FINERACT-726 . Please get in touch on the Fineract mailing list for faster replies :) |
conradsp
force-pushed
the
mojaloop-fineract_1.0
branch
5 times, most recently
from
7a3bce0 to
423243a
Compare
Contributor
|
Re-submitting this PR without the build changes |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
Integration tests have been created/updated for verifying the changes made.
All Integrations tests are passing with the new commit.
PR contains a single commit (If you have multiple commits, please squash them into a single commit).
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide