Skip to content

FINERACT-2455: WorkingCapital - % repayment modification options#5771

Merged
adamsaghy merged 2 commits into
apache:developfrom
openMF:FINERACT-2455/wc-period-payment-rate-change
May 12, 2026
Merged

FINERACT-2455: WorkingCapital - % repayment modification options#5771
adamsaghy merged 2 commits into
apache:developfrom
openMF:FINERACT-2455/wc-period-payment-rate-change

Conversation

@budaidev
Copy link
Copy Markdown
Contributor

@budaidev budaidev commented Apr 15, 2026 •
edited
Loading

WorkingCapital - % repayment modification options in the middle of the loan life cycle

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@budaidev budaidev force-pushed the FINERACT-2455/wc-period-payment-rate-change branch 3 times, most recently from 1a44be3 to ffff593 Compare April 16, 2026 20:42
@budaidev budaidev marked this pull request as ready for review April 16, 2026 20:43
@budaidev budaidev force-pushed the FINERACT-2455/wc-period-payment-rate-change branch from ffff593 to e1c7df0 Compare April 17, 2026 04:39
@budaidev budaidev changed the title FINERACT-2455: WorkingCapital - % repayment modification options in t… FINERACT-2455: WorkingCapital - % repayment modification options Apr 22, 2026
@adamsaghy
Copy link
Copy Markdown
Contributor

adamsaghy commented Apr 22, 2026

@budaidev Please rebase

@budaidev budaidev force-pushed the FINERACT-2455/wc-period-payment-rate-change branch 2 times, most recently from d556345 to 744409d Compare April 24, 2026 13:05
@adamsaghy
Copy link
Copy Markdown
Contributor

adamsaghy commented Apr 24, 2026

@budaidev Please rebase

@budaidev budaidev force-pushed the FINERACT-2455/wc-period-payment-rate-change branch 5 times, most recently from 53c4074 to 8608328 Compare April 26, 2026 19:00
Aman-Mittal
Aman-Mittal reviewed Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Aman-Mittal Aman-Mittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comments, reviewed based on code changes only. Currently no usecase doc in ticket or in code so i will not able to review based on Use Case implementation

Comment thread ...java/org/apache/fineract/portfolio/workingcapitalloan/api/WorkingCapitalLoanApiResource.java Outdated
Comment thread ...java/org/apache/fineract/portfolio/workingcapitalloan/api/WorkingCapitalLoanApiResource.java Outdated
Comment thread ...java/org/apache/fineract/portfolio/workingcapitalloan/api/WorkingCapitalLoanApiResource.java Outdated
Comment thread ...java/org/apache/fineract/portfolio/workingcapitalloan/api/WorkingCapitalLoanApiResource.java Outdated
Comment thread ...java/org/apache/fineract/portfolio/workingcapitalloan/api/WorkingCapitalLoanApiResource.java Outdated
@budaidev budaidev force-pushed the FINERACT-2455/wc-period-payment-rate-change branch from 8608328 to 5cad8ee Compare April 28, 2026 12:58
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-2455/wc-period-payment-rate-change branch 2 times, most recently from 98c6dbb to b261a90 Compare April 28, 2026 14:03
@budaidev budaidev force-pushed the FINERACT-2455/wc-period-payment-rate-change branch 4 times, most recently from 1572df9 to 9878cd2 Compare April 29, 2026 11:41
@adamsaghy
Copy link
Copy Markdown
Contributor

adamsaghy commented Apr 29, 2026

@budaidev Please rebase.

@budaidev budaidev force-pushed the FINERACT-2455/wc-period-payment-rate-change branch from 9878cd2 to 3335dd5 Compare April 29, 2026 14:40
adamsaghy
adamsaghy requested changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly review my concerns!

Also the calculator getting more complex, some comments which explain calculations should be added to help our work in the future.

@budaidev budaidev force-pushed the FINERACT-2455/wc-period-payment-rate-change branch 4 times, most recently from 1403499 to b586c82 Compare May 1, 2026 12:25
@budaidev budaidev requested a review from adamsaghy May 3, 2026 20:51
@budaidev budaidev force-pushed the FINERACT-2455/wc-period-payment-rate-change branch from b586c82 to e725cc8 Compare May 4, 2026 11:21
@budaidev budaidev marked this pull request as draft May 8, 2026 20:05
@budaidev budaidev force-pushed the FINERACT-2455/wc-period-payment-rate-change branch 4 times, most recently from e6daa6c to 6598d10 Compare May 11, 2026 09:34
@adamsaghy adamsaghy marked this pull request as ready for review May 11, 2026 13:19
@budaidev budaidev force-pushed the FINERACT-2455/wc-period-payment-rate-change branch 2 times, most recently from 95acc2c to cb5a30c Compare May 11, 2026 18:25
galovics
galovics requested changes May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@galovics galovics left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but couple of things as inline comments.

Comment thread ...changelog/tenant/module/workingcapitalloan/parts/0036_wc_loan_period_payment_rate_change.xml Outdated
Comment thread ...changelog/tenant/module/workingcapitalloan/parts/0036_wc_loan_period_payment_rate_change.xml
Comment thread ...che/fineract/portfolio/workingcapitalloan/serialization/WorkingCapitalLoanDataValidator.java Outdated
Comment thread ...che/fineract/portfolio/workingcapitalloan/serialization/WorkingCapitalLoanDataValidator.java Outdated
Comment thread ...che/fineract/portfolio/workingcapitalloan/serialization/WorkingCapitalLoanDataValidator.java
Comment thread ...ineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanWritePlatformServiceImpl.java Outdated
Comment thread ...tfolio/workingcapitalloan/service/WorkingCapitalLoanAmortizationScheduleReadServiceImpl.java Outdated
Comment thread ...folio/workingcapitalloan/service/WorkingCapitalLoanAmortizationScheduleWriteServiceImpl.java Outdated
Comment thread .../fineract/portfolio/workingcapitalloan/domain/WorkingCapitalLoanPeriodPaymentRateChange.java
Comment thread ...lio/workingcapitalloan/service/WorkingCapitalLoanPeriodPaymentRateChangeReadServiceImpl.java
@adamsaghy adamsaghy force-pushed the FINERACT-2455/wc-period-payment-rate-change branch from cb5a30c to ec24c2b Compare May 11, 2026 21:46
@budaidev budaidev force-pushed the FINERACT-2455/wc-period-payment-rate-change branch from ec24c2b to ea7eab4 Compare May 12, 2026 08:47
@adamsaghy adamsaghy force-pushed the FINERACT-2455/wc-period-payment-rate-change branch from ea7eab4 to ad3ea42 Compare May 12, 2026 08:54
adamsaghy
adamsaghy approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@budaidev budaidev requested a review from galovics May 12, 2026 09:21
@adamsaghy adamsaghy force-pushed the FINERACT-2455/wc-period-payment-rate-change branch from ad3ea42 to cde525b Compare May 12, 2026 10:44
@adamsaghy adamsaghy merged commit 8e35c89 into apache:develop May 12, 2026
53 of 54 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2455/wc-period-payment-rate-change branch May 12, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aman-Mittal Aman-Mittal Aman-Mittal left review comments

@adamsaghy adamsaghy adamsaghy approved these changes

@galovics galovics Awaiting requested review from galovics

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@budaidev @adamsaghy @galovics @Aman-Mittal