[FLINK-37104] Refactor transform module, code cleanup #3986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi. thx @yuxiqian . I will TAL. |
aiwenmo
approved these changes
Apr 12, 2025
Contributor
aiwenmo
left a comment
aiwenmo
left a comment
There was a problem hiding this comment.
LGTM. The logic of the refactored code is much clearer. All the tests have passed, and currently, I can't come up with better improvement suggestions. What I want to confirm is whether this PR should include the code improvement for Batch.
Member
Author
Contributor
Member
Author
|
Done rebasing & resolving conflicts. I removed batch-version PreTransformOpetator since it's basically the same as the streaming one. Could @aiwenmo please double check it? |
leonardBang
approved these changes
Apr 23, 2025
linjianchang
pushed a commit
to linjianchang/flink-cdc
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes FLINK-37104.
...by refactoring transform module to improve code readability and maintainability. No behavior changes are expected for all valid use cases.
Kindly ping @aiwenmo as he is the main developer of flink-runtime package.