-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-18206][table-api / sql-client] Fix the incorrect timestamp display #15658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @fsk119 Could you help take a look this PR? |
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit c45fa23 (Sat Aug 28 11:16:39 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/PrintUtils.java
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliUtils.java
Outdated
Show resolved
Hide resolved
...flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliChangelogResultView.java
Outdated
Show resolved
Hide resolved
...ble/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableResultView.java
Outdated
Show resolved
Hide resolved
...-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientITCase.java
Outdated
Show resolved
Hide resolved
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/PrintUtils.java
Outdated
Show resolved
Hide resolved
5eac2c7 to
3fb642a
Compare
wuchong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some final minor comments.
...able/flink-table-common/src/main/java/org/apache/flink/table/utils/TimestampStringUtils.java
Outdated
Show resolved
Hide resolved
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/PrintUtils.java
Outdated
Show resolved
Hide resolved
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/PrintUtils.java
Outdated
Show resolved
Hide resolved
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/PrintUtils.java
Outdated
Show resolved
Hide resolved
flink-table/flink-table-common/src/test/java/org/apache/flink/table/utils/PrintUtilsTest.java
Outdated
Show resolved
Hide resolved
...-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientITCase.java
Outdated
Show resolved
Hide resolved
1a8bf8e to
afdd1ac
Compare
wuchong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
Brief change log
DataTimeFormatteris aligned with TimeFormats inflink-table-commonVerifying this change
Add unit test for
PrintUtils, Add ITCase for Sql-ClientDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation