Skip to content

Conversation

@link3280
Copy link
Contributor

What is the purpose of the change

Currently, remove jar statement doesn't remove the corresponding jars in pipeline.jars, which should be fixed.

Brief change log

  • Replacing session dependencies instead of merging them into the new dependencies in remove-jar statements.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 13, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@link3280
Copy link
Contributor Author

CI failures are irrelevant, retrigger the pipeline.

@link3280
Copy link
Contributor Author

@flinkbot run azure

1 similar comment
@link3280
Copy link
Contributor Author

@flinkbot run azure

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great work.

Could you also add a case in the CliClientITCase? You can take a look at the file set.q[1] for more details.

[1] https://github.com/apache/flink/blob/master/flink-table/flink-sql-client/src/test/resources/sql/set.q#L128

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your update. Leave one minor suggestion.

@fsk119
Copy link
Member

fsk119 commented Mar 17, 2022

cc @leonardBang @wuchong

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your update. LGTM

@link3280
Copy link
Contributor Author

Thanks a lot for your review! @fsk119

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@leonardBang
Copy link
Contributor

@flinkbot run azure

@leonardBang
Copy link
Contributor

@link3280 Could you also open PRs for branch release-1.14 and release-1.15 ?

@link3280
Copy link
Contributor Author

@leonardBang Sure.

@leonardBang
Copy link
Contributor

@flinkbot run azure

@link3280
Copy link
Contributor Author

@leonardBang Opened 2 backport PR #19132 #19133

@leonardBang
Copy link
Contributor

@leonardBang Opened 2 backport PR #19132 #19133

Nice work!We need rebase this PR to latest master to pass the e2e tests, the e2e tests failed today and has been fixed in
cbf2ab0

@link3280
Copy link
Contributor Author

@leonardBang Done. Updating the other two PRs.

@link3280
Copy link
Contributor Author

@flinkbot run azure

1 similar comment
@link3280
Copy link
Contributor Author

@flinkbot run azure

@link3280
Copy link
Contributor Author

@leonardBang CI finally turns green. Could you merge this PR if possible? Thanks.

@leonardBang leonardBang merged commit 1b041db into apache:master Mar 19, 2022
@leonardBang
Copy link
Contributor

Thanks @link3280 for the continuous work, the Github infrastructure broken recently which influenced many project 😂.

golden-yang pushed a commit to golden-yang/flink that referenced this pull request Mar 19, 2022
JasonLeeCoding pushed a commit to JasonLeeCoding/flink that referenced this pull request May 27, 2022
zstraw pushed a commit to zstraw/flink that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants