-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-26618][sql-client] Fix Remove-Jar statement not effective #19070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI failures are irrelevant, retrigger the pipeline. |
|
@flinkbot run azure |
1 similar comment
|
@flinkbot run azure |
fsk119
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your great work.
Could you also add a case in the CliClientITCase? You can take a look at the file set.q[1] for more details.
...k-sql-client/src/main/java/org/apache/flink/table/client/gateway/context/SessionContext.java
Outdated
Show resolved
Hide resolved
fsk119
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your update. Leave one minor suggestion.
...k-sql-client/src/main/java/org/apache/flink/table/client/gateway/context/SessionContext.java
Outdated
Show resolved
Hide resolved
fsk119
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your update. LGTM
|
Thanks a lot for your review! @fsk119 |
leonardBang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
@flinkbot run azure |
|
@link3280 Could you also open PRs for branch |
|
@leonardBang Sure. |
|
@flinkbot run azure |
|
@leonardBang Opened 2 backport PR #19132 #19133 |
Nice work!We need rebase this PR to latest master to pass the e2e tests, the e2e tests failed today and has been fixed in |
|
@leonardBang Done. Updating the other two PRs. |
|
@flinkbot run azure |
1 similar comment
|
@flinkbot run azure |
|
@leonardBang CI finally turns green. Could you merge this PR if possible? Thanks. |
|
Thanks @link3280 for the continuous work, the Github infrastructure broken recently which influenced many project 😂. |
…ith pipeline jars This closes apache#19070.
…ith pipeline jars This closes apache#19070.
…ith pipeline jars This closes apache#19070.
What is the purpose of the change
Currently,
remove jarstatement doesn't remove the corresponding jars in pipeline.jars, which should be fixed.Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation