[FLINK-29436][build] Upgrade spotless for running on JDK 17

[tisonkun]

This blocker is fixed by: diffplug/spotless#1224 and diffplug/spotless#1228.

[flinkbot]

CI report:

• 57333f8 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[zentol]

Could there be a bug in that spotless version that the skip parameter is being ignored?

[tisonkun]

@zentol with this change I tested JDK 17 can work with spotless:

gh pr checkout 20911
mvn -nsu spotless:apply

... while it generates diff on:

• flink-connectors/flink-sql-connector-hive-3.1.2/src/main/java/org/apache/hadoop/hive/conf/HiveConf.java
• flink-connectors/flink-sql-connector-hive-3.1.2/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java

And I pushed a second commit for the change.

[tisonkun]

It seems the version bump cause this configure not work, I will try to find a reasonable followup:

			<!-- disable spotless since we need copy hive code -->
			<plugin>
				<groupId>com.diffplug.spotless</groupId>
				<artifactId>spotless-maven-plugin</artifactId>
				<configuration>
					<skip>true</skip>
				</configuration>
			</plugin>

Related issue: diffplug/spotless#1227

[tisonkun]

Pushed a workaround on the plugin configs. I'm submitting a patch for upstream to avoid such a workaround.

[zentol]

+1 % CI passing

[tisonkun]

@zentol thanks for your reviewing.

I've submitted a patch to the upstream diffplug/spotless#1353.

Supposed 1) we're not in a hurry on this change 2) it is not easily to conflict with other patches 3) upstream uses auto-release after a patch is merged. I suggest after CI passes we wait a few days (e.g., after the Chinese National Day holiday I'll come back on Oct. 8th) to try to eliminate the workaround in this patch.

[zentol]

Sure, let's wait for the release.

[tisonkun]

Upgrade to 2.27.1 and eliminate the workaround. Wait for the new CI report and merge.

[tisonkun]

@flinkbot run azure

[tisonkun]

Although test fails should be unrelated, IIRC someone said you should get CI passed to merge a patch, lol. Rerun.