[FLINK-11227] [table] The DescriptorProperties contains some bounds checking errors #7373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Thanks again for your reminding me of the bug in Best, Xingcan |
hequn8128
reviewed
Dec 28, 2018
| maxLength) | ||
| } | ||
|
|
||
| private def testFixedFieldsValidation(properties: DescriptorProperties): Unit = { |
Contributor
There was a problem hiding this comment.
How about rename testFixedFieldsValidation to testFixedIndexedPropertiesValidation?
| } | ||
|
|
||
| @Test(expected = classOf[ValidationException]) | ||
| def testInvalidFixedIndexedProperty(): Unit = { |
Member
Author
|
Thanks for the review @hequn8128. The methods are renamed according to your comments. Best, Xingcan |
Contributor
|
@xccui Thanks a lot for the update. +1 to merge. Best, Hequn |
twalthr
approved these changes
Jan 4, 2019
Contributor
twalthr
left a comment
twalthr
left a comment
There was a problem hiding this comment.
Thank you @xccui and @hequn8128. Merging...
asfgit
pushed a commit
that referenced
this pull request
Jan 4, 2019
tisonkun
pushed a commit
to tisonkun/flink
that referenced
this pull request
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR aims to fix the bounds checking errors for
validateFixedIndexedProperties()andvalidateArray()inDescriptorProperties.Brief change log
Change the upper bounds of the loops from
< maxIndexto<= maxIndex.Verifying this change
validateArray(), made the last element an invalid one.validateFixedIndexedProperties(), added a new test casevalidateFixedIndexedProperties().Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation