Skip to content

Conversation

@dianfu
Copy link
Contributor

@dianfu dianfu commented Jan 2, 2019

What is the purpose of the change

This pull request Fixes the visibility issue of distinct in Table API

Brief change log

(for example:)

  • Remove private[flink] of DistinctAggregateFunction#distinct
  • Remove private[flink] of DistinctAgg#distinct

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@sunjincheng121
Copy link
Member

@dianfu Thanks for the PR.
Will be merged.

@asfgit asfgit closed this in 3d88137 Jan 2, 2019
asfgit pushed a commit that referenced this pull request Jan 2, 2019
@dianfu
Copy link
Contributor Author

dianfu commented Jan 2, 2019

@sunjincheng121 Thanks a lot for the quick review and merge. :)

tisonkun pushed a commit to tisonkun/flink that referenced this pull request Jan 17, 2019
@dianfu dianfu deleted the fix_distinct_package branch June 10, 2020 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants