Skip to content

Conversation

@JaryZhen
Copy link

What is the purpose of the change

This pull request fix typo in time attributes docs

Brief change log

Fix typo in time attributes doc that DefinedRowtimeAttribute should be DefinedRowtimeAttributes. also, implemented getRowtimeAttributeDescriptors method in doc.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JaryZhen. Merging...

Copy link
Contributor

@hequn8128 hequn8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaryZhen Thanks a lot for the fixing! Looks good.
Best, Hequn

@asfgit asfgit closed this in 2be178c Jan 14, 2019
@twalthr
Copy link
Contributor

twalthr commented Jan 14, 2019

Sorry, @hequn8128. I saw your comment too late. I will fix this in a hotfix commit before porting it to the other branches. Thanks.

asfgit pushed a commit that referenced this pull request Jan 14, 2019
@JaryZhen
Copy link
Author

Hi, @twalthr I'd like to know why this PR finished by Closed not Merged ?

@twalthr
Copy link
Contributor

twalthr commented Jan 14, 2019

@JaryZhen there are two ways of merging PRs. Either via Github or via the Apache Gitbot. I used Gitbot with a the This closes #... string in the commit message:

f6da761

@JaryZhen
Copy link
Author

@twalthr thanks for tell me that. In addition, I noted that only a single rowtime attribute is support at the moment was wrote in sourceSink , so ... I think it's necessary to let user know in this page.

tisonkun pushed a commit to tisonkun/flink that referenced this pull request Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants