[VL] Gluten-it: Simplify CollectionConverter.scala#10533
Merged
philo-he merged 1 commit intoapache:mainfrom Aug 26, 2025
Merged
[VL] Gluten-it: Simplify CollectionConverter.scala#10533philo-he merged 1 commit intoapache:mainfrom
philo-he merged 1 commit intoapache:mainfrom
Conversation
Member
zhztheplayer
commented
Aug 26, 2025
zhztheplayer
commented
- Rename to JavaCollectionConverter.scala
- Simplify code
Member
Author
|
@philo-he Thanks |
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
force-pushed
the
wip-fix-it-2.13
branch
from
4819919 to
5b6147d
Compare
|
Run Gluten Clickhouse CI on x86 |
1. Rename to JavaCollectionConverter.scala 2. Simplify code
zhztheplayer
force-pushed
the
wip-fix-it-2.13
branch
from
5b6147d to
e2d5e34
Compare
|
Run Gluten Clickhouse CI on x86 |
philo-he
reviewed
Aug 26, 2025
|
|
||
| import scala.collection.immutable.{Map => IMap} | ||
| import scala.collection.immutable.{Seq => ISeq} | ||
| import scala.collection.JavaConverters._ |
Member
There was a problem hiding this comment.
I note scala.collection.JavaConverters has been marked ad deprecated in Scala 2.13. Do we need to use the recommended scala.jdk.CollectionConverters API for 2.13?
Member
Author
There was a problem hiding this comment.
No worries, the scala.collection.JavaConverters is kept in 2.13 for compatibility with 2.12. gluten-it supports both versions so it's a norm to access this API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.