[MINOR] Simplify numaBindingInfo for GlutenConfig#10557
[MINOR] Simplify numaBindingInfo for GlutenConfig#10557beliefer wants to merge 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
|
@zhouyuan, I'm curious if NUMA binding is still working well. It seems no tests cover this functionality, and no users are enabling it. |
|
We can remove the function. Linux Numa balancing works pretty well. |
|
@FelixYBW Do you means remove the |
Yes. feel free to remove it. It doesn't do better than NUMA_BALANCING. On machines with multiple NUMA, one should enable the NUMA_BALANCING in Linux. |
|
OK. let me remove it. |
The feature is inherited from Gazelle project. At that time we find it works well on physical servers. As far as I know there is no real deployment using this feature in production. |
|
Because #10579 has been merged. So I close this one. |
What changes are proposed in this pull request?
This PR proposes to simplify
numaBindingInfoforGlutenConfig.How was this patch tested?
GA tests.