Skip to content

[MINOR] Simplify numaBindingInfo for GlutenConfig#10557

Closed
beliefer wants to merge 1 commit intoapache:mainfrom
beliefer:improve-numaBindingInfo
Closed

[MINOR] Simplify numaBindingInfo for GlutenConfig#10557
beliefer wants to merge 1 commit intoapache:mainfrom
beliefer:improve-numaBindingInfo

Conversation

@beliefer
Copy link
Copy Markdown
Contributor

@beliefer beliefer commented Aug 27, 2025

What changes are proposed in this pull request?

This PR proposes to simplify numaBindingInfo for GlutenConfig.

How was this patch tested?

GA tests.

@github-actions github-actions bot added the CORE works for Gluten Core label Aug 27, 2025
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@beliefer
Copy link
Copy Markdown
Contributor Author

@philo-he
Copy link
Copy Markdown
Member

@zhouyuan, I'm curious if NUMA binding is still working well. It seems no tests cover this functionality, and no users are enabling it.

@FelixYBW
Copy link
Copy Markdown
Contributor

We can remove the function. Linux Numa balancing works pretty well.

@beliefer
Copy link
Copy Markdown
Contributor Author

@FelixYBW Do you means remove the numaBindingInfo?

@FelixYBW
Copy link
Copy Markdown
Contributor

@FelixYBW Do you means remove the numaBindingInfo?

Yes. feel free to remove it. It doesn't do better than NUMA_BALANCING. On machines with multiple NUMA, one should enable the NUMA_BALANCING in Linux.

@beliefer
Copy link
Copy Markdown
Contributor Author

OK. let me remove it.

@zhouyuan
Copy link
Copy Markdown
Member

@zhouyuan, I'm curious if NUMA binding is still working well. It seems no tests cover this functionality, and no users are enabling it.

The feature is inherited from Gazelle project. At that time we find it works well on physical servers. As far as I know there is no real deployment using this feature in production.

@beliefer
Copy link
Copy Markdown
Contributor Author

beliefer commented Sep 1, 2025

Because #10579 has been merged. So I close this one.

@beliefer beliefer closed this Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants